FelixYBW commented on code in PR #9869:
URL: https://github.com/apache/incubator-gluten/pull/9869#discussion_r2133163925
##########
cpp/velox/shuffle/VeloxShuffleWriter.h:
##########
@@ -136,7 +134,7 @@ class VeloxShuffleWriter : public ShuffleWriter {
// Memory Pool used to track memory usage of partition buffers.
// The actual allocation is delegated to options_.memoryPool.
- std::unique_ptr<ShuffleMemoryPool> partitionBufferPool_;
+ std::shared_ptr<arrow::MemoryPool> partitionBufferPool_;
Review Comment:
I see. it's used by ptr.lock(). Add a comment here that
VeloxShuffleWritter owns the ownership actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
