zhztheplayer commented on code in PR #9957:
URL: https://github.com/apache/incubator-gluten/pull/9957#discussion_r2142055504
##########
gluten-core/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -117,6 +117,9 @@ class GlutenConfig(conf: SQLConf) extends Logging {
def enableExtendedColumnPruning: Boolean =
getConf(ENABLE_EXTENDED_COLUMN_PRUNING)
+ def enableEnhancedFeature(): Boolean =
+ System.getenv().getOrDefault("GLUTEN_ENABLE_ENHANCED_FEATURE",
"false").toBoolean
+
Review Comment:
Should this be defined in `GlutenConfig.scala` or in `VeloxConfig.scala`?
And it feels worth it to add an individual JNI method to avoid relying on
the env?
E.g.,
```java
native boolean isEnhancedFeaturesEnabled();
```
More generally in the future, we may have
```java
native String[] getEnabledEnhancedFeatures();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
