zhouyuan commented on code in PR #9957:
URL: https://github.com/apache/incubator-gluten/pull/9957#discussion_r2142190563


##########
.github/workflows/velox_backend_cache.yml:
##########
@@ -106,6 +106,34 @@ jobs:
           path: '${{ env.CCACHE_DIR }}'
           key: ccache-centos8-release-shared-${{runner.arch}}-${{github.sha}}
 
+  cache-enhanced-shared-lib-centos-8:
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ ubuntu-22.04 ]
+    container: apache/gluten:centos-8-jdk8
+    steps:
+      - uses: actions/checkout@v2
+      - name: Get Ccache
+        uses: actions/cache/restore@v3
+        with:
+          path: '${{ env.CCACHE_DIR }}'
+          key: 
ccache-enhanced-centos8-release-shared-${{runner.arch}}-${{github.sha}}

Review Comment:
   could we reuse the centos8-shared cache? by default the cache size for each 
project is relatively small(10G)



##########
ep/build-velox/src/get_velox.sh:
##########
@@ -20,17 +20,22 @@ VELOX_REPO=https://github.com/oap-project/velox.git
 VELOX_BRANCH=2025_06_11
 VELOX_HOME=""
 RUN_SETUP_SCRIPT=ON
+VELOX_ENHANCED_REPO=https://github.com/oap-project/velox.git
+VELOX_ENHANCED_BRANCH=2025_06_10

Review Comment:
   since new CI is added for this feature and sometimes the gluten:main code is 
tightly coupled with velox rebase branch. so on each rebase we may need to take 
care of these two branches 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to