PHILO-HE commented on code in PR #9955:
URL: https://github.com/apache/incubator-gluten/pull/9955#discussion_r2144120421
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,102 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: build
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk
+ export MAVEN_HOME=/usr/lib/maven
+ export PATH=${PATH}:${MAVEN_HOME}/bin:${JAVA_HOME}/bin
+ cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler-vcpkg:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: build
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk
+ export MAVEN_HOME=/usr/lib/maven
+ export PATH=${PATH}:${MAVEN_HOME}/bin:${JAVA_HOME}/bin
+ export VCPKG_PATH=/var/cache/vcpkg
+ export VCPKG_BINARY_SOURCES="clear;files,${VCPKG_PATH},readwrite"
+ cd $GITHUB_WORKSPACE/
+ ./dev/vcpkg/setup-build-depends.sh
+ mkdir -p ${VCPKG_PATH}
+ sed -i 's/--build_arrow=OFF/--build_arrow=ON/' dev/package-vcpkg.sh
&& ./dev/package-vcpkg.sh
+ mkdir -p $GITHUB_WORKSPACE/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
$GITHUB_WORKSPACE/.m2/repository/org/apache/arrow/
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-openeuler-24-${{github.sha}}
+ path: ./cpp/build/releases/
+ if-no-files-found: error
+ - uses: actions/upload-artifact@v4
+ with:
+ name: arrow-jars-openeuler-24-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
+ if-no-files-found: error
+
+ tpc-test-openeuler:
Review Comment:
I think it may be better to simply start a docker to run this tpc-h test in
the above `build-on-openeuler-vcpkg` job after the build. Then, no need to
upload artifacts, but only need to mount some paths to the docker, e.g., mount
.m2 to include arrow jars, and mount $GITHUB_WORKSPACE to include native libs
at /cpp/build/releases/ and gluten source code.
By doing so, we can reduce the complexity.
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,102 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: build
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk
+ export MAVEN_HOME=/usr/lib/maven
+ export PATH=${PATH}:${MAVEN_HOME}/bin:${JAVA_HOME}/bin
+ cd $GITHUB_WORKSPACE/ && ./dev/package.sh
Review Comment:
You can start a docker here to run a tpc-h test also. Please set
`spark.gluten.loadLibFromJar=true` to make sure all required native libs packed
in third-party jar are loaded at runtime.
The code path of loading lib from jar is not verified in CI. We are
considering to add this test for other OS in subsequent pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
