PHILO-HE commented on code in PR #9955:
URL: https://github.com/apache/incubator-gluten/pull/9955#discussion_r2151207949
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,68 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/package.sh
+ cp package/target/thirdparty-lib/gluten-thirdparty-lib-*.jar /root/
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8
+ - name: Run TPC-H
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ cp /root/gluten-thirdparty-lib-*.jar package/target/lib/
+ GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
+ --local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1 \
+ --extra-conf=spark.gluten.loadLibFromJar=true \
+ --extra-conf=spark.gluten.loadLibOS=openEuler
--extra-conf=spark.gluten.loadLibOSVersion=24.03
Review Comment:
Use the proposed env variable with extra configs appended.
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,68 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/package.sh
+ cp package/target/thirdparty-lib/gluten-thirdparty-lib-*.jar /root/
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
Review Comment:
Without spark version specified, package.sh will build gluten for all
supported Spark versions, including spark-3.5. To avoid redundant build and
unnecessary build, please use `./deve/package.sh --spark_version=3.5` and
remove the above `mvn clean install` command.
If `mvn install` is necessary in gluten-it test, I think we can directly
modify `buildbundle-veloxbe.sh` (called by package.sh) to replace `mvn clean
pakcage` with `mvn clean install`.
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,68 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/package.sh
+ cp package/target/thirdparty-lib/gluten-thirdparty-lib-*.jar /root/
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8
+ - name: Run TPC-H
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ cp /root/gluten-thirdparty-lib-*.jar package/target/lib/
+ GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
+ --local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1 \
+ --extra-conf=spark.gluten.loadLibFromJar=true \
+ --extra-conf=spark.gluten.loadLibOS=openEuler
--extra-conf=spark.gluten.loadLibOSVersion=24.03
+
+ build-on-openeuler-vcpkg:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/vcpkg/setup-build-depends.sh
+ ./dev/package-vcpkg.sh --build_arrow=ON
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8
+ - name: Run TPC-H
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
+ --local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1
Review Comment:
Nit:
To reduce duplication, please create an env variable, like `TPCH_TEST`, in
the `env` section of this file to use it in the two jobs and future new jobs.
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,68 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/package.sh
+ cp package/target/thirdparty-lib/gluten-thirdparty-lib-*.jar /root/
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8
+ - name: Run TPC-H
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/tools/gluten-it
+ cp /root/gluten-thirdparty-lib-*.jar package/target/lib/
+ GLUTEN_IT_JVM_ARGS=-Xmx5G sbin/gluten-it.sh queries-compare \
+ --local --preset=velox --benchmark-type=h --error-on-memleak
--off-heap-size=10g -s=1.0 --threads=16 --iterations=1 \
+ --extra-conf=spark.gluten.loadLibFromJar=true \
+ --extra-conf=spark.gluten.loadLibOS=openEuler
--extra-conf=spark.gluten.loadLibOSVersion=24.03
+
+ build-on-openeuler-vcpkg:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/vcpkg/setup-build-depends.sh
+ ./dev/package-vcpkg.sh --build_arrow=ON
+ $MVN_CMD clean install -Pspark-3.5 -Pjava-8 -Pbackends-velox
-DskipTests
Review Comment:
ditto
##########
.github/workflows/velox_weekly.yml:
##########
@@ -99,3 +100,68 @@ jobs:
sudo apt-get install -y openjdk-8-jdk
export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
cd $GITHUB_WORKSPACE/ && ./dev/package.sh
+
+ build-on-openeuler:
+ strategy:
+ fail-fast: false
+ matrix:
+ os: [ "openeuler/openeuler:24.03" ]
+ if: ${{ startsWith(github.repository, 'apache/') }}
+ runs-on: ubuntu-24.04-arm
+ container: ${{ matrix.os }}
+ steps:
+ - uses: actions/checkout@v4
+ - name: Install dependencies
+ run: |
+ dnf update -y && dnf install -y java-1.8.0-openjdk-devel sudo patch
wget git perl
+ $SETUP install_maven
+ echo "JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk" >> $GITHUB_ENV
+ - name: Build
+ run: |
+ echo "JAVA_HOME: $JAVA_HOME"
+ cd $GITHUB_WORKSPACE/
+ ./dev/package.sh
+ cp package/target/thirdparty-lib/gluten-thirdparty-lib-*.jar /root/
Review Comment:
Maybe, we can directly copy the jar to package/target/lib/ if we only use
`./deve/package.sh --spark_version=3.5` to build gluten.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
