jinchengchenghh commented on code in PR #9957: URL: https://github.com/apache/incubator-gluten/pull/9957#discussion_r2151157248
########## ep/build-velox/src/get_velox.sh: ########## @@ -20,17 +20,22 @@ VELOX_REPO=https://github.com/oap-project/velox.git VELOX_BRANCH=2025_06_11 VELOX_HOME="" RUN_SETUP_SCRIPT=ON +VELOX_ENHANCED_REPO=https://github.com/oap-project/velox.git +VELOX_ENHANCED_BRANCH=2025_06_10 Review Comment: Yes, I place it here because it is easy to update daily and understand. If we move it to the logic, it might be hard for user to find the repo and branch. Now it is configurable, user can set --velox_repo and --velox_branch to specify the enhanced feature branch. Do I need to update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
