kapilks commented on code in PR #10030:
URL:
https://github.com/apache/incubator-gluten/pull/10030#discussion_r2160701187
##########
gluten-substrait/src/main/scala/org/apache/gluten/extension/columnar/rewrite/ProjectColumnPruning.scala:
##########
@@ -34,6 +34,7 @@ object ProjectColumnPruning extends RewriteSingleNode {
if (unusedAttribute.nonEmpty) {
val newProject = project.copy(projectList =
project.projectList.diff(unusedAttribute.toSeq))
+ newProject.copyTagsFrom(project)
Review Comment:
`.copy` doesn't copy tags as it's auto generated by scala.
There is `makeCopy` method in Spark plan which handles tags copying but it
is not used frequently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
