zhztheplayer commented on PR #10030: URL: https://github.com/apache/incubator-gluten/pull/10030#issuecomment-2995733767
> Also, I am pretty sure there are a few other places where we forget to copy tags and/or set logical links, Yes I agreed. > but these don't cause any test to fail This may happen, because I think tags are not widely relied by critical code paths either in Spark and Gluten. I can tell Spark CBO may need the logical links for cost evaluation however CBO is by default off. And in Gluten we have the fallback tags but the use of them are only scoped in one rules or two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
