zml1206 commented on code in PR #10036:
URL:
https://github.com/apache/incubator-gluten/pull/10036#discussion_r2161656350
##########
backends-velox/src/main/scala/org/apache/gluten/extension/PullOutDuplicateProject.scala:
##########
@@ -60,13 +60,13 @@ object PullOutDuplicateProject extends Rule[SparkPlan] with
PredicateHelper {
bhj.streamedPlan.asInstanceOf[ProjectExecTransformer],
bhj.references,
pullOutAliases)
+ val newBhj = bhj.joinBuildSide match {
+ case BuildLeft => bhj.copy(right = newStreamedPlan)
+ case BuildRight => bhj.copy(left = newStreamedPlan)
+ }
if (pullOutAliases.isEmpty) {
Review Comment:
Thanks for the fix, at present, pullOutAliases cannot determine whether
rewriting is needed. We can separate the calculation of duplicates from
rewriteProject and use duplicates to determine whether rewriting is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
