zhztheplayer commented on code in PR #10183:
URL:
https://github.com/apache/incubator-gluten/pull/10183#discussion_r2206223011
##########
gluten-substrait/src/main/scala/org/apache/spark/sql/execution/datasources/GlutenWriterColumnarRules.scala:
##########
@@ -127,6 +127,8 @@ object GlutenWriterColumnarRules {
if (format.isDefined) {
spark.sparkContext.setLocalProperty("isNativeApplicable", true.toString)
spark.sparkContext.setLocalProperty("nativeFormat", format.get)
+ // The flag for static-only write is not used by Velox backend where
+ // the static partition write is already supported.
spark.sparkContext.setLocalProperty(
"staticPartitionWriteOnly",
Review Comment:
Sounds reasonable. I didn't remove it in this PR because I found some usages
in CH. But not sure whether they are actually using it. So it is kept here at
the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
