zhztheplayer commented on code in PR #10183:
URL:
https://github.com/apache/incubator-gluten/pull/10183#discussion_r2206245630
##########
shims/spark32/src/main/scala/org/apache/spark/sql/execution/datasources/FileFormatWriter.scala:
##########
@@ -291,15 +287,10 @@ object FileFormatWriter extends Logging {
empty2NullPlan,
Some(ConcurrentOutputWriterSpec(maxWriters, () =>
sortPlan.createSorter())))
} else {
- if (staticPartitionWriteOnly && nativeEnabled) {
Review Comment:
I debugged on this. And it seems we have `orderingMatched = true` in the
case that all the partitions are static. So this code path will not be invoked.
Would you help me confirm that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
