zhouyuan commented on code in PR #10190:
URL:
https://github.com/apache/incubator-gluten/pull/10190#discussion_r2208028621
##########
docs/Configuration.md:
##########
@@ -1,130 +1,162 @@
+<!-- DO NOT MODIFY THIS FILE DIRECTLY, IT IS AUTO-GENERATED BY
[org.apache.gluten.config.AllGlutenConfiguration] -->
+
---
+
layout: page
title: Configuration
nav_order: 3
----
-
-# Spark Configurations for Gluten Plugin
-
-There are many configurations could impact the Gluten Plugin performance and
can be fine-tuned in Spark.
-You can add these configurations into spark-defaults.conf to enable or disable
the setting.
-
-## Spark parameters
-
-| Parameters | Description
| Recommend Setting
|
-|---------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|------------------------------------------------------|
-| spark.driver.extraClassPath | Gluten
Plugin jar file to prepend to the classpath of the driver.
| /path/to/jar_file
|
Review Comment:
It looks like we missed some essential parameters like
spark.extraClassPath/spark.plugins/org.apache.spark.shuffle.sort.ColumnarShuffleManager
here
##########
docs/velox-configuration.md:
##########
@@ -0,0 +1,81 @@
+<!-- DO NOT MODIFY THIS FILE DIRECTLY, IT IS AUTO-GENERATED BY
[org.apache.gluten.config.AllVeloxConfiguration] -->
+
+---
+
+layout: page
+title: Configuration
+nav_order: 3
Review Comment:
may need to use different number for the nav_order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
