FelixYBW commented on PR #10190: URL: https://github.com/apache/incubator-gluten/pull/10190#issuecomment-3106530038
@yikf Some configurations are defined different default value in scala and c++. Like https://github.com/apache/incubator-gluten/blob/35f516cf2298c83be723cdd75fa71489a6317e54/gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala#L577-L579 and https://github.com/apache/incubator-gluten/blob/d7560eaa9401e55e7be6595f54dafcaf70b59b5e/cpp/velox/config/VeloxConfig.h#L115 Is there good way to handle this? One possible solution is to set invalid value in c++ to make sure the config should always be passed from java or external config. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
