zhztheplayer commented on code in PR #10249:
URL:
https://github.com/apache/incubator-gluten/pull/10249#discussion_r2224426974
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -444,6 +444,13 @@ bool VeloxMemoryManager::tryDestructSafe() {
return true;
}
+void VeloxMemoryManager::finalDestructUnsafe() {
+ heldVeloxPools_.clear();
+ veloxLeafPool_.reset();
+ veloxAggregatePool_.reset();
+ veloxMemoryManager_.reset();
Review Comment:
This destruction order should already be guaranteed as it's the reversed
order where they are defined. Are we missing something here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
