zhztheplayer commented on code in PR #10249:
URL:
https://github.com/apache/incubator-gluten/pull/10249#discussion_r2227137121
##########
cpp/velox/memory/VeloxMemoryManager.cc:
##########
@@ -444,6 +444,13 @@ bool VeloxMemoryManager::tryDestructSafe() {
return true;
}
+void VeloxMemoryManager::finalDestructUnsafe() {
+ heldVeloxPools_.clear();
+ veloxLeafPool_.reset();
+ veloxAggregatePool_.reset();
+ veloxMemoryManager_.reset();
Review Comment:
Thank you for the explanation. Would like to know how the change is
currently tested from your end. Is the issue reproducible locally?
I assume after some certain patches were landed into Velox, there's barely
such case as the memory manager needs to wait when being destructed. But if the
destruction is triggered by an error thrown from task, waiting may still be
needed. Like to know more about your case as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
