zhztheplayer commented on code in PR #9768:
URL: https://github.com/apache/incubator-gluten/pull/9768#discussion_r2266495612
##########
shims/common/src/main/scala/org/apache/gluten/execution/BatchCarrierRowBase.scala:
##########
@@ -35,7 +34,7 @@ import org.apache.spark.unsafe.types.{CalendarInterval,
UTF8String}
* PlaceholderRows, followed by one TerminalRow that actually wraps that
columnar batch. The total
* number of PlaceholderRows + the TerminalRow equates to the size of the
original columnar batch.
*/
-sealed abstract class BatchCarrierRow extends InternalRow {
+abstract class BatchCarrierRowBase extends InternalRow {
Review Comment:
We can avoid shiming this class by making `BatchCarrierRow` extend a mixin
trait. I'll help update the PR for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
