zhztheplayer commented on code in PR #9768:
URL: https://github.com/apache/incubator-gluten/pull/9768#discussion_r2267015999
##########
gluten-ui/pom.xml:
##########
@@ -66,6 +66,66 @@
</dependency>
</dependencies>
+<profiles>
+ <profile>
+ <id>spark-4.0</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <configuration>
+ <target>
+ <replaceregexp
file="src/main/scala/org/apache/spark/sql/execution/ui/GlutenAllExecutionsPage.scala"
+ match="import javax.servlet"
+ replace="import
jakarta.servlet"
+ byline="true"/>
+ </target>
+ </configuration>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>!spark-4.0</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <executions>
+ <execution>
+ <phase>generate-sources</phase>
+ <configuration>
+ <target>
+ <replaceregexp
file="src/main/scala/org/apache/spark/sql/execution/ui/GlutenAllExecutionsPage.scala"
Review Comment:
It's a Scala class so we may be able to add a type shim in the shim layers
to avoid such hacking? E.g.,
```scala
type HttpServletRequestShim = javax.servlet.http.HttpServletRequest
```
##########
shims/common/src/main/scala/org/apache/spark/sql/connector/catalog/functions/Reducer.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.connector.catalog.functions;
+
+import org.apache.spark.annotation.Evolving;
+
+// Copied from Spark for Gluten temporary use.
+// TODO: remove this and move code depends on this class to shims.
+
+/**
+ * A 'reducer' for output of user-defined functions.
+ *
+ * @see ReducibleFunction
+ *
+ * A user defined function f_source(x) is 'reducible' on another user_defined
function
+ * f_target(x) if
+ * <ul>
+ * <li> There exists a reducer function r(x) such that r(f_source(x)) =
f_target(x) for
+ * all input x, or </li>
+ * <li> More generally, there exists reducer functions r1(x) and r2(x) such
that
+ * r1(f_source(x)) = r2(f_target(x)) for all input x. </li>
+ * </ul>
+ *
+ * @param <I> reducer input type
+ * @param <O> reducer output type
+ * @since 4.0.0
+ */
+@Evolving
+public interface Reducer<I, O> {
Review Comment:
The class duplicates the one from vanilla Spark. I think we need to place it
to all 3.x shims instead? Although it's tedious than the current practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
