zhli1142015 commented on code in PR #10357:
URL: 
https://github.com/apache/incubator-gluten/pull/10357#discussion_r2278120744


##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -778,6 +780,14 @@ object GlutenConfig {
       .booleanConf
       .createWithDefault(true)
 
+  val GLUTEN_ANSI_FALLBACK_ENABLED =
+    buildConf("spark.gluten.sql.ansiFallback.enabled")

Review Comment:
   This config does the same thing as an existing one.
   I think it would be better to add a whitelist-like config to cover the 
functions that are already supported, and then fall back the plan based on it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to