nimesh1601 commented on code in PR #10357:
URL:
https://github.com/apache/incubator-gluten/pull/10357#discussion_r2278131852
##########
gluten-substrait/src/main/scala/org/apache/gluten/config/GlutenConfig.scala:
##########
@@ -778,6 +780,14 @@ object GlutenConfig {
.booleanConf
.createWithDefault(true)
+ val GLUTEN_ANSI_FALLBACK_ENABLED =
+ buildConf("spark.gluten.sql.ansiFallback.enabled")
Review Comment:
@zhli1142015 This config allows us to bypass global ANSI fallback. So even
if any user has enabled ANSI, it would still fallback until user consciously
take call to allow ANSI.
A better solution is to have a function whitelist, but as of now, the
majority of functions and operators rely on global ANSI fallback and thus have
not implemented fallback like arithmetic operators. So, if we just have a
whitelist without implementing fallback logic in those operators/functions, it
might cause data errors. We can take this up of implementing fallbacks and
whitelist in subsequent PRs . wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
