PHILO-HE commented on code in PR #10537: URL: https://github.com/apache/incubator-gluten/pull/10537#discussion_r2306663365
########## backends-clickhouse/src-celeborn/main/scala/org/apache/spark/shuffle/CHCelebornColumnarBatchSerlizerFactory.scala: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.shuffle + +import org.apache.gluten.backendsapi.BackendsApiManager +import org.apache.spark.shuffle.gluten.celeborn.CelebornColumnarBatchSerializerFactory + +class CHCelebornColumnarBatchSerlizerFactory extends CelebornColumnarBatchSerializerFactory { Review Comment: typo: \*Serializer\* ########## gluten-celeborn/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornShuffleManager.java: ########## @@ -95,20 +95,18 @@ public class CelebornShuffleManager celebornColumnarBatchSerializerFactoriesLoader.iterator(), CelebornColumnarBatchSerializerFactory.class)) .collect(Collectors.toList()); - // for now, we ignore check since CH backend has not support this feature yet. - // Preconditions.checkState( - // !columnarBatchSerializerFactoryList.isEmpty(), - // "No factory found for Celeborn columnar batch serializer"); + + Preconditions.checkState( + !columnarBatchSerializerFactoryList.isEmpty(), + "No factory found for Celeborn columnar batch serializer"); final Map<String, CelebornColumnarBatchSerializerFactory> columanrBatchSerilizerFactoryMap = columnarBatchSerializerFactoryList.stream() .collect(Collectors.toMap(CelebornColumnarBatchSerializerFactory::backendName, f -> f)); - // for now, we ignore check since CH backend has not support this feature yet. - // if (!columanrBatchSerilizerFactoryMap.containsKey(backendName)) { - // throw new UnsupportedOperationException( - // "No Celeborn columnar batch serializer writer factory found for backend " + - // backendName); - // } + if (!columanrBatchSerilizerFactoryMap.containsKey(backendName)) { Review Comment: Typo: columnar* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
