zjuwangg commented on code in PR #10537:
URL:
https://github.com/apache/incubator-gluten/pull/10537#discussion_r2309030545
##########
gluten-celeborn/src/main/java/org/apache/spark/shuffle/gluten/celeborn/CelebornShuffleManager.java:
##########
@@ -95,21 +95,19 @@ public class CelebornShuffleManager
celebornColumnarBatchSerializerFactoriesLoader.iterator(),
CelebornColumnarBatchSerializerFactory.class))
.collect(Collectors.toList());
- // for now, we ignore check since CH backend has not support this
feature yet.
- // Preconditions.checkState(
- // !columnarBatchSerializerFactoryList.isEmpty(),
- // "No factory found for Celeborn columnar batch serializer");
- final Map<String, CelebornColumnarBatchSerializerFactory>
columanrBatchSerilizerFactoryMap =
+
+ Preconditions.checkState(
+ !columnarBatchSerializerFactoryList.isEmpty(),
+ "No factory found for Celeborn columnar batch serializer");
+ final Map<String, CelebornColumnarBatchSerializerFactory>
columnarBatchSerilizerFactoryMap =
columnarBatchSerializerFactoryList.stream()
.collect(Collectors.toMap(CelebornColumnarBatchSerializerFactory::backendName,
f -> f));
- // for now, we ignore check since CH backend has not support this
feature yet.
- // if (!columanrBatchSerilizerFactoryMap.containsKey(backendName)) {
- // throw new UnsupportedOperationException(
- // "No Celeborn columnar batch serializer writer factory found
for backend " +
- // backendName);
- // }
- columnarBatchSerializerFactory =
columanrBatchSerilizerFactoryMap.get(backendName);
+ if (!columnarBatchSerilizerFactoryMap.containsKey(backendName)) {
Review Comment:
I think you are right. Just open a issue to track this insightful idea
https://github.com/apache/incubator-gluten/issues/10577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
