kevinwilfong commented on code in PR #10569:
URL:
https://github.com/apache/incubator-gluten/pull/10569#discussion_r2308147758
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -141,12 +141,24 @@ class VeloxIteratorApi extends IteratorApi with Logging {
val planByteArray = wsCtx.root.toProtobuf.toByteArray
splitInfos.zipWithIndex.map {
- case (splitInfos, index) =>
+ case (splits, index) =>
+ val splitsByteArray = splits.zipWithIndex.map {
Review Comment:
When you say inject it into the substrait plan do you mean in the ReadRel?
If so definitely, this was something I was already considering I just wasn't
sure how open folks are to updating the substrait protobufs, I borrowed this
approach from what's already done in the code for ClickHouse.
We could probably deprecate the schema field in FileOrFiles. It looks like
the only place it's used is that ClickHouse code path, and there it looks like
it's put there because they only want to set it when the file is in the
TextFile format, we could probably change that logic to only consume the field
if it's in the TextFile format if that's not already the way it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
