Yohahaha commented on code in PR #10569:
URL:
https://github.com/apache/incubator-gluten/pull/10569#discussion_r2309032168
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -141,12 +141,24 @@ class VeloxIteratorApi extends IteratorApi with Logging {
val planByteArray = wsCtx.root.toProtobuf.toByteArray
splitInfos.zipWithIndex.map {
- case (splitInfos, index) =>
+ case (splits, index) =>
+ val splitsByteArray = splits.zipWithIndex.map {
Review Comment:
> When you say inject it into the substrait plan do you mean in the ReadRel?
yes, you can try modify
`gluten-substrait/src/main/resources/substrait/proto/substrait/algebra.proto`
> We could probably deprecate the schema field in FileOrFiles
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
