zjuwangg commented on code in PR #10667:
URL:
https://github.com/apache/incubator-gluten/pull/10667#discussion_r2340877605
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -524,6 +524,74 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
}
}
+ test("optimize sort window to streaming window") {
+ withSQLConf(VeloxConfig.COLUMNAR_VELOX_WINDOW_TYPE.key -> "sort") {
Review Comment:
> Just curious why you choose to use sort window not straeming window in you
env? Because the sort operator already before the window opeartor, and then we
can directly use the StreamigWindow in velox side.
In fact, in our env we also using streaming window instead of sort window.
But we observed such optimization can be made when sort window is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
