zjuwangg commented on code in PR #10667:
URL:
https://github.com/apache/incubator-gluten/pull/10667#discussion_r2340883077
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -524,6 +524,74 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
}
}
+ test("optimize sort window to streaming window") {
+ withSQLConf(VeloxConfig.COLUMNAR_VELOX_WINDOW_TYPE.key -> "sort") {
Review Comment:
> plan to remove the SortWindow type and switch to using the
StreamingWindow directly, since Spark already inserts a sort operator before
the window operator.
Also make sense to me.
##########
backends-velox/src/test/scala/org/apache/gluten/execution/MiscOperatorSuite.scala:
##########
@@ -524,6 +524,74 @@ class MiscOperatorSuite extends
VeloxWholeStageTransformerSuite with AdaptiveSpa
}
}
+ test("optimize sort window to streaming window") {
+ withSQLConf(VeloxConfig.COLUMNAR_VELOX_WINDOW_TYPE.key -> "sort") {
Review Comment:
> plan to remove the SortWindow type and switch to using the
StreamingWindow directly, since Spark already inserts a sort operator before
the window operator.
Also make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
