PHILO-HE commented on code in PR #10248:
URL:
https://github.com/apache/incubator-gluten/pull/10248#discussion_r2354659788
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -190,4 +196,45 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss");
+ List<Row> rows =
+ Arrays.asList(
+ Row.of(1, LocalDateTime.parse("2024-12-31 12:12:12", formatter)),
+ Row.of(2, LocalDateTime.parse("2025-02-28 12:12:12", formatter)));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b Timestamp(3)",
rows);
+ String query =
+ "select a, DATE_FORMAT(b, 'yyyy-MM-dd'), DATE_FORMAT(b, 'yyyy-MM-dd
HH:mm:ss') from dateFormatTbl";
+ runAndCheck(
+ query,
+ Arrays.asList(
+ "+I[1, 2024-12-31, 2024-12-31 12:12:12]", "+I[2, 2025-02-28,
2025-02-28 12:12:12]"));
+
+ Map<String, String> configs = new HashMap<>();
+ configs.put(TableConfigOptions.LOCAL_TIME_ZONE.key(),
"America/Los_Angeles");
+ rows =
+ Arrays.asList(
+ Row.of(
+ 1, LocalDateTime.parse("2024-12-31 12:12:12",
formatter).toInstant(ZoneOffset.UTC)),
+ Row.of(
+ 2,
+ LocalDateTime.parse("2025-02-28 12:12:12",
formatter).toInstant(ZoneOffset.UTC)));
+ createSimpleBoundedValuesTable("dateFormatTblLTZ", "a int, b
Timestamp_LTZ(3)", rows);
+ String query1 =
Review Comment:
Nit: maybe, just use "query = " to overwrite the previous value.
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -190,4 +196,45 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss");
+ List<Row> rows =
+ Arrays.asList(
+ Row.of(1, LocalDateTime.parse("2024-12-31 12:12:12", formatter)),
+ Row.of(2, LocalDateTime.parse("2025-02-28 12:12:12", formatter)));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b Timestamp(3)",
rows);
+ String query =
+ "select a, DATE_FORMAT(b, 'yyyy-MM-dd'), DATE_FORMAT(b, 'yyyy-MM-dd
HH:mm:ss') from dateFormatTbl";
+ runAndCheck(
+ query,
+ Arrays.asList(
+ "+I[1, 2024-12-31, 2024-12-31 12:12:12]", "+I[2, 2025-02-28,
2025-02-28 12:12:12]"));
+
+ Map<String, String> configs = new HashMap<>();
+ configs.put(TableConfigOptions.LOCAL_TIME_ZONE.key(),
"America/Los_Angeles");
Review Comment:
I note in Flink, the following code can be called to set timezone. It may be
better to directly call such API to do the setting before the test. Then, no
need to do the setting inside `runAndCheck`.
```java
tEnv.getConfig().setLocalTimeZone(ZoneId.of("Asia/Shanghai"));
```
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -190,4 +196,45 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss");
+ List<Row> rows =
+ Arrays.asList(
+ Row.of(1, LocalDateTime.parse("2024-12-31 12:12:12", formatter)),
+ Row.of(2, LocalDateTime.parse("2025-02-28 12:12:12", formatter)));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b Timestamp(3)",
rows);
+ String query =
+ "select a, DATE_FORMAT(b, 'yyyy-MM-dd'), DATE_FORMAT(b, 'yyyy-MM-dd
HH:mm:ss') from dateFormatTbl";
+ runAndCheck(
+ query,
+ Arrays.asList(
+ "+I[1, 2024-12-31, 2024-12-31 12:12:12]", "+I[2, 2025-02-28,
2025-02-28 12:12:12]"));
Review Comment:
I assume the result will not be impacted by local time zone. Could you add a
repeat test with a local time zone set firstly?
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -190,4 +196,45 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss");
+ List<Row> rows =
+ Arrays.asList(
+ Row.of(1, LocalDateTime.parse("2024-12-31 12:12:12", formatter)),
+ Row.of(2, LocalDateTime.parse("2025-02-28 12:12:12", formatter)));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b Timestamp(3)",
rows);
Review Comment:
Nit:
Use descriptive table name: timestampTable,
##########
gluten-flink/runtime/src/main/java/org/apache/gluten/table/runtime/config/VeloxQueryConfig.java:
##########
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gluten.table.runtime.config;
+
+import io.github.zhztheplayer.velox4j.config.Config;
+
+import org.apache.flink.api.common.functions.RuntimeContext;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.streaming.api.operators.StreamingRuntimeContext;
+import org.apache.flink.table.api.config.TableConfigOptions;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class VeloxQueryConfig {
+
+ private static final String keyVeloxAdjustTimestampToSessionTimeZone =
+ "adjust_timestamp_to_session_timezone";
+ private static final String keyVeloxSessionTimezone = "session_timezone";
+
+ public static Config getConfig(RuntimeContext context) {
+ if (!(context instanceof StreamingRuntimeContext)) {
+ return Config.empty();
+ }
+ Configuration config = ((StreamingRuntimeContext)
context).getJobConfiguration();
+ Map<String, String> configMap = new HashMap<>();
+ configMap.put(keyVeloxAdjustTimestampToSessionTimeZone, "true");
+ String localTimeZone = config.get(TableConfigOptions.LOCAL_TIME_ZONE);
+ if
(TableConfigOptions.LOCAL_TIME_ZONE.defaultValue().equals(localTimeZone)) {
+ configMap.put(keyVeloxSessionTimezone, "UTC");
Review Comment:
Could you explain this code?
##########
gluten-flink/ut/src/test/java/org/apache/gluten/table/runtime/stream/custom/ScalarFunctionsTest.java:
##########
@@ -190,4 +196,45 @@ void testDecimal() {
query = "select b + e as x from tblDecimal where a > 0";
runAndCheck(query, Arrays.asList("+I[2.0]", "+I[5.0]", "+I[7.0]"));
}
+
+ @Test
+ void testDateFormat() {
+ DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss");
+ List<Row> rows =
+ Arrays.asList(
+ Row.of(1, LocalDateTime.parse("2024-12-31 12:12:12", formatter)),
+ Row.of(2, LocalDateTime.parse("2025-02-28 12:12:12", formatter)));
+ createSimpleBoundedValuesTable("dateFormatTbl", "a int, b Timestamp(3)",
rows);
+ String query =
+ "select a, DATE_FORMAT(b, 'yyyy-MM-dd'), DATE_FORMAT(b, 'yyyy-MM-dd
HH:mm:ss') from dateFormatTbl";
+ runAndCheck(
+ query,
+ Arrays.asList(
+ "+I[1, 2024-12-31, 2024-12-31 12:12:12]", "+I[2, 2025-02-28,
2025-02-28 12:12:12]"));
+
+ Map<String, String> configs = new HashMap<>();
+ configs.put(TableConfigOptions.LOCAL_TIME_ZONE.key(),
"America/Los_Angeles");
+ rows =
+ Arrays.asList(
+ Row.of(
+ 1, LocalDateTime.parse("2024-12-31 12:12:12",
formatter).toInstant(ZoneOffset.UTC)),
+ Row.of(
+ 2,
+ LocalDateTime.parse("2025-02-28 12:12:12",
formatter).toInstant(ZoneOffset.UTC)));
+ createSimpleBoundedValuesTable("dateFormatTblLTZ", "a int, b
Timestamp_LTZ(3)", rows);
Review Comment:
dateFormatTblLTZ->timestampLtzTable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
