PHILO-HE commented on PR #10248: URL: https://github.com/apache/incubator-gluten/pull/10248#issuecomment-3310716542
@KevinyhZou, you can change the CI code to use your Velox branch for testing, then to see if your patch can fix this failure. Another question. With the code below that maps Flink Timestamp type to Velox Timestamp type, I am curious how to distinguish timestamp with timezone and timestamp without timezone at Velox side, given that Flink LocalZonedTimestampType is mapped to Velox Timestamp type also. https://github.com/apache/incubator-gluten/blob/4d2a200c45d6a8849124d6eed4d54f1ae48568fd/gluten-flink/runtime/src/main/java/org/apache/gluten/util/LogicalTypeConverter.java#L67-L69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
