JkSelf commented on PR #8931: URL: https://github.com/apache/incubator-gluten/pull/8931#issuecomment-3310747995
> I understand it's a huge effort, appreciate for that @JkSelf. > > But let's find a way to avoid replacing the file `SQLExecution.scala` which is a hot path and extremely important for Spark. > > I expected [the approach](https://github.com/apache/incubator-gluten/pull/8931#discussion_r2287365279) in my comment might work and let me know if having any issue with it. @zhztheplayer You're right, this PR is quite large. The SQLExecution change is only needed to fix GlutenInjectRuntimeFilterSuite. I'll temporarily disable this test and address it in a follow-up PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
