WangGuangxin commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2340646115
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -306,6 +308,29 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
rightNode,
getJoinOutputType(leftNode, rightNode, joinType));
+ } else if (
+ sJoin.has_advanced_extension() &&
+ SubstraitParser::configSetInOptimization(sJoin.advanced_extension(),
"isBHJ=")) {
+ std::string hashTableId = sJoin.hashtableid();
+ void* hashTableAddress = nullptr;
+ try {
+ hashTableAddress =
ObjectStore::retrieve<facebook::velox::exec::BaseHashTable>(getJoin(hashTableId)).get();
Review Comment:
Can you point out where to assign the hash table to ObjectStore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
