wForget commented on code in PR #10916:
URL:
https://github.com/apache/incubator-gluten/pull/10916#discussion_r2450289817
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -118,6 +118,7 @@ private object GlutenDriverPlugin extends Logging {
// 1GB default
1024 * 1024 * 1024
}
+ conf.set(GlutenCoreConfig.SPARK_OFFHEAP_SIZE_KEY, "0")
Review Comment:
> When DYNAMIC_OFFHEAP_SIZING_ENABLED is enabled, the memory used by Velox
is tracked under the on-heap category by the Spark memory manager, so Ithink
there is no need to enable off-heap memory.
Thanks, that makes sense to me. @zhouyuan Can we point this out in the
documentation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
