zhouyuan commented on code in PR #10916:
URL:
https://github.com/apache/incubator-gluten/pull/10916#discussion_r2451581104
##########
gluten-core/src/main/scala/org/apache/gluten/GlutenPlugin.scala:
##########
@@ -118,6 +118,7 @@ private object GlutenDriverPlugin extends Logging {
// 1GB default
1024 * 1024 * 1024
}
+ conf.set(GlutenCoreConfig.SPARK_OFFHEAP_SIZE_KEY, "0")
Review Comment:
@wForget for now if dynamic offheap sizing feature is enabled, the spark
off-heap settings will be override(ignored). We have already documented a bit
on this behavior in below doc.
https://github.com/apache/incubator-gluten/blob/main/docs/developers/VeloxDynamicSizingOffheap.md#dynamic-off-heap-sizing
I should add WARN log here if off-heap related settings are detected, so
users may pay more attention on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
