marin-ma commented on PR #10984: URL: https://github.com/apache/incubator-gluten/pull/10984#issuecomment-3473264237
@jinchengchenghh I think for shuffle, we still can stick with adding different writer type. Again the shuffle writer type is a match for different shuffle reader deserialisation, and using different writer type it's easy to distinguish them from avoiding introducing params like "isRssShuffle", "isGpuShuffle", etc. Moreover, `ShuffleWriterType.name` is the display string on Spark UI. We can easily tell whether the shuffle is gpu shuffle with this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
