jinchengchenghh commented on PR #10984:
URL: 
https://github.com/apache/incubator-gluten/pull/10984#issuecomment-3473623497

   I find I also  need to update shuffle writer, but shuffleWriterType does not 
send to native, do you have any suggestion? @marin-ma 
   ```
             nativeShuffleWriter = if (isSort) {
               shuffleWriterJniWrapper.createSortShuffleWriter(
                 numPartitions,
                 dep.nativePartitioning.getShortName,
                 GlutenShuffleUtils.getStartPartitionId(
                   dep.nativePartitioning,
                   taskContext.partitionId),
                 conf.get(SHUFFLE_DISK_WRITE_BUFFER_SIZE).toInt,
                 conf.get(SHUFFLE_SORT_INIT_BUFFER_SIZE).toInt,
                 conf.get(SHUFFLE_SORT_USE_RADIXSORT),
                 partitionWriterHandle
               )
             } else {
               shuffleWriterJniWrapper.createHashShuffleWriter(
                 numPartitions,
                 dep.nativePartitioning.getShortName,
                 GlutenShuffleUtils.getStartPartitionId(
                   dep.nativePartitioning,
                   taskContext.partitionId),
                 nativeBufferSize,
                 reallocThreshold,
                 partitionWriterHandle
               )
             }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to