zhztheplayer commented on code in PR #10999:
URL:
https://github.com/apache/incubator-gluten/pull/10999#discussion_r2485903102
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -253,7 +253,7 @@ object IcebergScanTransformer {
}
def supportsBatchScan(scan: Scan): Boolean = {
- scan.getClass.getName ==
"org.apache.iceberg.spark.source.SparkBatchQueryScan"
+ scan.getClass == GlutenIcebergSourceUtil.getClassOfSparkBatchQueryScan
Review Comment:
Note: Equality check on class: Java `equals`or Scala `==` depends on class
loader. If the class was loaded by a custom class loader in the 3rd plugin,
this quality may be tested false negative. Having said that, this is a
theoretical risk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
