PHILO-HE commented on code in PR #10999:
URL:
https://github.com/apache/incubator-gluten/pull/10999#discussion_r2489078317
##########
gluten-iceberg/src/main/scala/org/apache/gluten/execution/IcebergScanTransformer.scala:
##########
@@ -253,7 +253,7 @@ object IcebergScanTransformer {
}
def supportsBatchScan(scan: Scan): Boolean = {
- scan.getClass.getName ==
"org.apache.iceberg.spark.source.SparkBatchQueryScan"
+ scan.getClass == GlutenIcebergSourceUtil.getClassOfSparkBatchQueryScan
Review Comment:
The failure comes from the ClassNotFoundException for SparkBatchQueryScan.
I just noted that CH backend module has its own definition for iceberg
component. As velox backend, we also need to add validation check to determine
if the component should be registered. Then, we can relatively safely use these
iceberg class references. Just updated the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
