zhztheplayer commented on code in PR #11032:
URL:
https://github.com/apache/incubator-gluten/pull/11032#discussion_r2502858944
##########
gluten-arrow/src/main/scala/org/apache/gluten/runtime/Runtimes.scala:
##########
@@ -40,7 +40,7 @@ object Runtimes {
throw new IllegalStateException("This method must be called in a Spark
task.")
}
TaskResources.addResourceIfNotRegistered(
- s"$backendName:$name",
+ s"$backendName:$name:${extraConf.hashCode()}",
Review Comment:
Thank you for updating. I got what's happening here.
The code will work in most cases but there's a small chance that two
different `extraConf` instance procude the same hashCode which is unexpected.
To address this, maybe we can either always create new instance with a
unique ID in name (with `addResource`), or to pass `${extraConf}` for getting
an instance from cache (with `addResourceIfNotRegistered`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
