zhztheplayer commented on code in PR #11032:
URL:
https://github.com/apache/incubator-gluten/pull/11032#discussion_r2502910895
##########
gluten-arrow/src/main/scala/org/apache/gluten/runtime/Runtimes.scala:
##########
@@ -29,4 +31,17 @@ object Runtimes {
s"$backendName:$name",
() => Runtime(backendName, name))
}
+
+ def newInstance(
Review Comment:
If `addResourceIfNotRegistered` is called then the mothod name should be
`contextInstance` for accuracy. Then we can make the other method
`contextInstance(backendName: String, name: String)` a shortcut to this one, or
merge the two methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
