Zouxxyy opened a new pull request, #11264:
URL: https://github.com/apache/incubator-gluten/pull/11264
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/incubator-gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid
duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR
title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
Currently, Velox's `AggregationNode` only supports a single grouping keys
list,
```cpp
AggregationNode(
const PlanNodeId& id,
Step step,
const std::vector<FieldAccessTypedExprPtr>& groupingKeys,
const std::vector<FieldAccessTypedExprPtr>& preGroupedKeys,
const std::vector<std::string>& aggregateNames,
const std::vector<Aggregate>& aggregates,
bool ignoreNullKeys,
PlanNodePtr source);
```
whereas the groupings field in `AggregateRel` is actually a list of grouping
keys list.
```
message AggregateRel {
...
repeated Grouping groupings = 3;
message Grouping {
repeated Expression grouping_expressions = 1;
}
...
}
```
Therefore, the correct conversion is:
- Map `AggregateRel.groupings[0]` to `AggregationNode`'s `groupingKeys`,
- And throw an exception if the number of groupings is greater than 1.
## What changes are proposed in this pull request?
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after
updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the
corresponding issue
when the PR is merged.
-->
## How was this patch tested?
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
