Zouxxyy commented on PR #11264: URL: https://github.com/apache/incubator-gluten/pull/11264#issuecomment-3639922082
> So then root cause is that Velox's AggregationNode can't use a single grouping set to simulate multiple groups as below > > ``` > [groupings[0].key[0],groupings[0].key[1],groupings[1].key[0],groupings[1].key[1]] > ``` > > we have to implement multiple groups support in AggregationNode. > > Right? Yes, it only accept ``` [groupings[0].key[0],groupings[0].key[1],groupings[0].key[2],groupings[0].key[3]] ``` BTY, in the case of multiple groups, the aggregates functions also need to be a list of list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
