malinjawi commented on PR #11437: URL: https://github.com/apache/incubator-gluten/pull/11437#issuecomment-3767115928
> @malinjawi, thanks for drafting this PR. We generally implement Spark functions in Velox, not in Gluten. I suggest firstly evaluating Velox's existing implementation for cast to see if we can just add if/else branch for ANSI support or add a separate implementation (if most code is not shared). > > Velox is now aware of the Spark ANSI setting. So you may get the ANSI enabling state from Velox config to implement some branching logic if needed. > > With the cast implemented in Velox, I assume most test cases proposed for Gluten can be moved to Velox. Thanks for the reply @PHILO-HE I’ll move the implementation into Velox and evaluate the existing cast path there, using the Spark ANSI setting exposed via Velox config. Just to confirm from a Gluten integration perspective: once the cast behavior is implemented and tested in Velox, are there any additional changes or validation needed in Gluten itself (e.g., wiring, config propagation, or integration tests), or should the Velox src/test coverage be sufficient? I want to make sure I’m aligning with the expected ownership and test boundaries going forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
