marin-ma commented on PR #11437: URL: https://github.com/apache/incubator-gluten/pull/11437#issuecomment-3767751929
> Just to confirm from a Gluten integration perspective: once the cast behavior is implemented and tested in Velox, are there any additional changes or validation needed in Gluten itself (e.g., wiring, config propagation, or integration tests), or should the Velox src/test coverage be sufficient? You can add `GlutenCastWithAnsiOnSuite`by following the same approach used to add `GlutenCastWithAnsiOffSuite`, and only include the test cases related to "cast from string to boolean" in `VeloxTestSettings`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
