PHILO-HE commented on code in PR #11515:
URL:
https://github.com/apache/incubator-gluten/pull/11515#discussion_r2752688424
##########
dev/docker/Dockerfile.centos8-static-build:
##########
@@ -47,6 +46,6 @@ RUN set -ex; \
export SSL_VERIFY=false; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
--enable_hdfs=ON --enable_abfs=ON
build_arrow; \
- mvn dependency:go-offline -Pbackends-velox -Piceberg -Pdelta -Pspark-3.5
-DskipTests; \
+ ./build/mvn dependency:go-offline -Pbackends-velox -Piceberg -Pdelta
-Pspark-3.5 -DskipTests; \
Review Comment:
@yaooqinn, since `build/mvn` fully accepts using the installed maven in the
environment, I feel it may be better to keep maven installed in the docker's
system path to save CI resources, though it's a small cost.
If we are concerned about the incompatibility, maybe, we can add some check
logic in build/mvn to only allow some versions to use. cc @zhouyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
