yaooqinn commented on code in PR #11515:
URL:
https://github.com/apache/incubator-gluten/pull/11515#discussion_r2752750303
##########
dev/docker/Dockerfile.centos8-static-build:
##########
@@ -47,6 +46,6 @@ RUN set -ex; \
export SSL_VERIFY=false; \
bash ./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_tests=ON
--enable_s3=ON --enable_gcs=ON \
--enable_hdfs=ON --enable_abfs=ON
build_arrow; \
- mvn dependency:go-offline -Pbackends-velox -Piceberg -Pdelta -Pspark-3.5
-DskipTests; \
+ ./build/mvn dependency:go-offline -Pbackends-velox -Piceberg -Pdelta
-Pspark-3.5 -DskipTests; \
Review Comment:
> If we are concerned about the incompatibility, maybe, we can add some
check logic in build/mvn to only allow some versions to use.
An old maven version caused quite a bit of unexpected issues during my
lifespan spark contributing. I'd like to make the subsequent build steps use
the up-to-date pom-defined maven version consistently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
