PHILO-HE commented on code in PR #11495:
URL:
https://github.com/apache/incubator-gluten/pull/11495#discussion_r2754793323
##########
gluten-core/src/main/scala/org/apache/gluten/execution/GlutenPlan.scala:
##########
@@ -59,7 +59,9 @@ trait GlutenPlan
override def batchType(): Convention.BatchType
- override def rowType0(): Convention.RowType
+ override def rowType(): Convention.RowType = rowType0()
+
+ def rowType0(): Convention.RowType
Review Comment:
Can we remove this?
##########
gluten-substrait/pom.xml:
##########
@@ -267,6 +267,10 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
+ <configuration>
+ <!-- Ensure Scala compiles to the same output dir so Java can see
Scala classes -->
+ <outputDirectory>${project.build.outputDirectory}</outputDirectory>
+ </configuration>
Review Comment:
Did you see some errors without these new code? I am wondering why we need
this. If it is indeed necessary, can we move the plugin configuration into root
pom for consistency?
##########
gluten-core/src/main/scala/org/apache/spark/util/SparkPlanUtil.scala:
##########
@@ -23,16 +23,12 @@ import org.apache.spark.sql.internal.SQLConf
object SparkPlanUtil {
def supportsRowBased(plan: SparkPlan): Boolean = {
- if (SparkVersionUtil.lteSpark32) {
- return !plan.supportsColumnar
- }
-
val m = classOf[SparkPlan].getMethod("supportsRowBased")
m.invoke(plan).asInstanceOf[Boolean]
}
def isPlannedV1Write(plan: DataWritingCommandExec): Boolean = {
- if (SparkVersionUtil.lteSpark33) {
+ if (SparkVersionUtil.compareMajorMinorVersion((3, 3)) <= 0) {
Review Comment:
Suggest using `eqSpark33` instead, since no need to consider earlier
versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
