QCLyu commented on code in PR #11495:
URL:
https://github.com/apache/incubator-gluten/pull/11495#discussion_r2757546663
##########
gluten-substrait/pom.xml:
##########
@@ -267,6 +267,10 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
+ <configuration>
+ <!-- Ensure Scala compiles to the same output dir so Java can see
Scala classes -->
+ <outputDirectory>${project.build.outputDirectory}</outputDirectory>
+ </configuration>
Review Comment:
Thanks @PHILO-HE Yes. The offline build failures were the “cannot find
symbol” errors in gluten-substrait's Java code (e.g. ConverterUtils,
SubstraitContext, GlutenConfig). Those can also be caused by:
-Incremental/stale build (e.g. mvn clean compile fixing it)
-Scala and Java writing to different output dirs when a module overrides
project.build.outputDirectory (e.g.
target/scala-${scala.binary.version}/classes)
I'll move the configuration to the root POM and remove it from
gluten-substrait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
