QCLyu commented on code in PR #11687:
URL:
https://github.com/apache/incubator-gluten/pull/11687#discussion_r2887329169
##########
shims/common/src/main/scala/org/apache/gluten/sql/shims/SparkShims.scala:
##########
@@ -278,32 +212,11 @@ trait SparkShims {
def withAnsiEvalMode(expr: Expression): Boolean = false
- def dateTimestampFormatInReadIsDefaultValue(csvOptions: CSVOptions,
timeZone: String): Boolean
-
def createParquetFilters(
conf: SQLConf,
schema: MessageType,
caseSensitive: Option[Boolean] = None): ParquetFilters
- def genDecimalRoundExpressionOutput(decimalType: DecimalType, toScale: Int):
DecimalType = {
Review Comment:
We need to ensure the base trait's default implementation handles all Spark
versions correctly, or that the method is also removed from the
SparkPlanExecApi trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
