zhouyuan commented on code in PR #11687:
URL:
https://github.com/apache/incubator-gluten/pull/11687#discussion_r2891507195
##########
shims/common/src/main/scala/org/apache/gluten/sql/shims/SparkShims.scala:
##########
@@ -85,34 +76,19 @@ object SparkShimDescriptor {
}
trait SparkShims {
- // for this purpose, change HashClusteredDistribution to
ClusteredDistribution
- // https://github.com/apache/spark/pull/32875
- def getDistribution(leftKeys: Seq[Expression], rightKeys: Seq[Expression]):
Seq[Distribution]
def scalarExpressionMappings: Seq[Sig]
def aggregateExpressionMappings: Seq[Sig]
def runtimeReplaceableExpressionMappings: Seq[Sig]
- def convertPartitionTransforms(partitions: Seq[Transform]): (Seq[String],
Option[BucketSpec])
-
def generateFileScanRDD(
Review Comment:
We may better add a note on when/why these shim APIs are introduced for
future changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
