zhztheplayer commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2895286956
##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -84,12 +89,13 @@ jint JNI_OnLoad(JavaVM* vm, void*) {
createGlobalClassReferenceOrError(env,
"Lorg/apache/spark/sql/execution/datasources/BlockStripes;");
blockStripesConstructor = getMethodIdOrError(env, blockStripesClass,
"<init>", "(J[J[II[[B)V");
- batchWriteMetricsClass =
- createGlobalClassReferenceOrError(env,
"Lorg/apache/gluten/metrics/BatchWriteMetrics;");
+ batchWriteMetricsClass = createGlobalClassReferenceOrError(env,
"Lorg/apache/gluten/metrics/BatchWriteMetrics;");
batchWriteMetricsConstructor = getMethodIdOrError(env,
batchWriteMetricsClass, "<init>", "(JIJJ)V");
DLOG(INFO) << "Loaded Velox backend.";
+ gluten::vm = vm;
Review Comment:
This doesn't seem to be prohibited. But where is the variable used in the PR?
##########
cpp/velox/jni/VeloxJniWrapper.cc:
##########
@@ -84,12 +89,13 @@ jint JNI_OnLoad(JavaVM* vm, void*) {
createGlobalClassReferenceOrError(env,
"Lorg/apache/spark/sql/execution/datasources/BlockStripes;");
blockStripesConstructor = getMethodIdOrError(env, blockStripesClass,
"<init>", "(J[J[II[[B)V");
- batchWriteMetricsClass =
- createGlobalClassReferenceOrError(env,
"Lorg/apache/gluten/metrics/BatchWriteMetrics;");
+ batchWriteMetricsClass = createGlobalClassReferenceOrError(env,
"Lorg/apache/gluten/metrics/BatchWriteMetrics;");
batchWriteMetricsConstructor = getMethodIdOrError(env,
batchWriteMetricsClass, "<init>", "(JIJJ)V");
DLOG(INFO) << "Loaded Velox backend.";
+ gluten::vm = vm;
Review Comment:
This doesn't seem to be prohibited. But where is the variable used in the
PR? @JkSelf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
