liujiayi771 commented on code in PR #8931:
URL: https://github.com/apache/incubator-gluten/pull/8931#discussion_r2896360761


##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxSparkPlanExecApi.scala:
##########
@@ -678,9 +682,136 @@ class VeloxSparkPlanExecApi extends SparkPlanExecApi {
       child: SparkPlan,
       numOutputRows: SQLMetric,
       dataSize: SQLMetric): BuildSideRelation = {
+
+    val buildKeys = mode match {

Review Comment:
   I previously tried adding a pre-project to the join using the pullout 
pre-project framework. Do you think implementing this via rules would be more 
concise?
   I can continue to see if this PR can be completed.
   Could you help check if this is similar to your requirements here? 
https://github.com/apache/incubator-gluten/pull/10851



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to