guowangy commented on code in PR #11722:
URL: https://github.com/apache/gluten/pull/11722#discussion_r2915546898
##########
cpp/core/shuffle/LocalPartitionWriter.cc:
##########
@@ -759,6 +881,12 @@ arrow::Status
LocalPartitionWriter::sortEvict(uint32_t partitionId,
std::unique_ptr<InMemoryPayload> inMemoryPayload, bool isFinal, int64_t&
evictBytes) {
rawPartitionLengths_[partitionId] += inMemoryPayload->rawSize();
+ if (usePartitionMultipleSegments_) {
+ // If multiple segments per partition is enabled, write directly to the
final data file.
+ RETURN_NOT_OK(writeMemoryPayload(partitionId, std::move(inMemoryPayload)));
Review Comment:
Reduce memory usage does not apply to sortEvict since it is usually
triggered at spill.
But it is applicable for hashEvict because payloads don't need cache to
memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
